Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Only open / once #649

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

cgwalters
Copy link
Collaborator

We juggle multiple things we call in different places the "rootfs", in some the container's root, in others the target root.

Add a handy member variable of State for the container root and use it consistently. This improves clarity now, and is prep for later patches.

We juggle multiple things we call in different places the "rootfs",
in some the container's root, in others the target root.

Add a handy member variable of `State` for the container root
and use it consistently. This improves clarity now, and
is prep for later patches.

Signed-off-by: Colin Walters <[email protected]>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Jun 28, 2024
Copy link
Contributor

@ckyrouac ckyrouac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this will be handy

@cgwalters cgwalters merged commit 591e998 into containers:main Jun 28, 2024
14 of 19 checks passed
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
…1.0.200

build(deps): bump serde from 1.0.199 to 1.0.200
cgwalters added a commit to cgwalters/bootc that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants